-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new security-questions module #295
add new security-questions module #295
Conversation
@Adamkadaban did you run Ruff against this? If you are using poetry: |
@Marshall-Hallenbeck Oh sorry, I didn't - but I have now. made the necessary changes and all checks are passing |
Quick question but since these informations are dumped calling the SAMR RPC endpoint, can't we simply add this module in the code --sam option ? |
@Dfte I considered this too. I would say yes, but afaik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the I think this means your impacket is outdated |
Oh yes, it's late, missed the fortra PR notice. Gonna update impacket and try again👍🏼 |
this module will dump security questions and answers for all users on the machine assuming run as administrator requires this PR to work: fortra/impacket#1743
this can happen when json is `{"version":1,"questions":[]}`
f8b7a02
to
39b877a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just requesting some variable renames so it's Python3-Pythonic.
… hasnt security questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
this module will dump security questions and answers for all users on the machine assuming run as administrator
requires this PR to work: fortra/impacket#1743
Reference: https://hackback.zip/2024/05/08/Remotely-Dumping-Windows-Security-Questions-With-Impacket.html
Type of change
How has this been tested?
Only tested against windows 10 and windows 11.
Ran e2e tests
Screenshots
example output shows
<Username> - <Question>: <Answer>
for each userChecklist
poetry run python -m ruff check . --preview
, use--fix
to automatically fix what it can)